feat: support for trending categories (gaming, trailers, ...) #7592
Conversation
|
It might make sense to hide the tab layout when there's only one category available (so in case Piped is used)? |
There was a problem hiding this comment.
When changing tabs by directly jumping to a tab some of the tabs around are loaded as well. It would be great if we could avoid the additional requests.
It might make sense to hide the tab layout when there's only one category available (so in case Piped is used)?
I think that depends on how Piped intends to deal with them. With how it currently is I would just hide everything related to trending, considering that the default trending backend will be fully removed at some point and the piped backend hasn't seen any commit in a while. If they update, I agree we should hide the tabs.
|
|
||
| class TrendsViewModel : ViewModel() { | ||
| val trendingVideos = MutableLiveData<List<StreamItem>>() | ||
| val trendingVideos = MutableLiveData<Map<TrendingCategory, List<StreamItem>>>() |
There was a problem hiding this comment.
We should initialize this with the trending content with already have from the home page, to avoid the additional request.
There was a problem hiding this comment.
I agree, but that'd be better off in a different PR, since this one focuses only on adding the new kiosk tabs
app/src/main/java/com/github/libretube/api/NewPipeMediaServiceRepository.kt
Show resolved
Hide resolved
|
Newpipe does not support : "music videos" |
Bnyro
force-pushed
the
trending-categories
branch
from
55a27f1 to
975cf89
Compare
We're interrupting the previous requests now, I doubt there's any better way (except if we wait a few 100ms before doing the initial request). |
3 participants
Planned for the homepage redesign with MD3 Expressive:
This doesn't yet really fit into the UI imo, that's why I want to incorporate that with the Expressive PR.