refactor: use videoId for storing downloaded files
#7576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves to using the videoId directly as the unique filename identifier, as they are already unique and do contain any reserved path characters. This also fixes a regression in 4407b26, where the filename would only contain disallowed characters.
Bnyro
reviewed
Jul 31, 2025
Member
Bnyro
left a comment
Bnyro
left a comment
There was a problem hiding this comment.
TextUtils.RESERVED_CHARSis no longer used, so it can be dropped.- I just looked around for usage of
filename, and it seems that we neither use the videoId nor anything else that's video specific forSubtitlepaths when converting to aDownloadItem, see https://github.com/libre-tube/LibreTube/blob/master/app/src/main/java/com/github/libretube/api/obj/Subtitle.kt#L31. So the paths there likely have never been unique, since neither the usedname(language name) norcode(language code) are unique??? Either I'm missing something, or we should also change that better sooner than later.
Uses `videoId` for the filepath to store the downloaded subtitles. This ensures, that filepath is unique per video.
Bnyro
approved these changes
Aug 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves to using the videoId directly as the unique filename identifier, as they are already unique and do contain any reserved path characters. This also fixes a regression in 4407b26, where the filename would only contain disallowed characters.