Skip to content

Chore: Remove context parameter from InstanceRepository #7466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2025
+4 −6
Merged

Chore: Remove context parameter from InstanceRepository #7466

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a2d954d
Refactor: Remove context parameter from InstanceRepository
SEKI-YUTA May 31, 2025
36be2ba
Refactor: remove unused imports in InstanceRepository
SEKI-YUTA May 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions app/src/main/java/com/github/libretube/api/InstanceRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,12 @@
package com.github.libretube.api

import android.content.Context
import com.github.libretube.R
import com.github.libretube.api.RetrofitInstance.PIPED_API_URL
import com.github.libretube.api.obj.PipedInstance
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
import okhttp3.HttpUrl.Companion.toHttpUrl

class InstanceRepository(private val context: Context) {
class InstanceRepository {

/**
* Fetch official public instances from kavin.rocks
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/github/libretube/ui/models/WelcomeViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class WelcomeViewModel(
val Factory: ViewModelProvider.Factory = viewModelFactory {
initializer {
WelcomeViewModel(
instanceRepository = InstanceRepository(this[APPLICATION_KEY]!!),
instanceRepository = InstanceRepository(),
savedStateHandle = createSavedStateHandle(),
)
}
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/java/com/github/libretube/ui/preferences/InstanceSettings.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,10 @@ class InstanceSettings : BasePreferenceFragment() {

lifecycleScope.launch {
// update the instances to also show custom ones
initInstancesPref(instancePrefs, InstanceRepository(appContext).getInstancesFallback())
initInstancesPref(instancePrefs, InstanceRepository().getInstancesFallback())

// try to fetch the public list of instances async
val instanceRepo = InstanceRepository(appContext)
val instanceRepo = InstanceRepository()
val instances = instanceRepo.getInstances()
.onFailure {
appContext.toastFromMainDispatcher(it.message.orEmpty())
Expand Down
Loading