Skip to content

Conversation

@FineFindus
Copy link
Collaborator

Drops the legacy subscription view, which was marked as legacy ~3 years ago. Given the long time, lack of updates since, it should be safe to remove. This further reduces the amount of 'unnecessary' options.

Ref: #7276
Ref: 298023b
Closes: #7403

Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that this is a good step, but since this option has probably been used by tablet users mostly, we should think about improving the default subscriptions view for large screens (e.g. respecting the grid column preference and putting multiple channels in a row). Otherwise with tablets in landscape, you only have the channel avarar + name at the left and then a lot of blank space until the subscribe button.

@FineFindus
Copy link
Collaborator Author

Maybe we could rethink the design and use bottom sheet instead? That way the current design would work on most screen sizes.

@Bnyro
Copy link
Member

Bnyro commented May 10, 2025

Maybe we could rethink the design and use bottom sheet instead? That way the current design would work on most screen sizes.

I don't mind rethinking the design, but wouldn't a bottom sheet just make it more complicated to browse the subcriptions? Although it coiluld for instance allow us to add a search feature for subscribed channels (like in the channel groups menu), so that could be nice too.

@Bnyro Bnyro force-pushed the feat/drop-legacy-view branch from cd786aa to 6fb0dc7 Compare September 12, 2025 18:04
@Bnyro Bnyro merged commit 28ffe3d into libre-tube:master Sep 12, 2025
3 checks passed
@FineFindus FineFindus deleted the feat/drop-legacy-view branch September 12, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rename "Legacy subscriptions view" to "Grid subscriptions view"

2 participants