Skip to content

Conversation

@FineFindus
Copy link
Collaborator

Fixes an issue, with local mode enabled, users where unable to continously load channel data.
This was caused by the channel nextpage data being stored as a JVM identifier (the default byte array .toString behaviour), rather than the expected base64 encoded string.

Closes: #7240

@FineFindus FineFindus marked this pull request as ready for review March 25, 2025 19:58
@FineFindus FineFindus changed the title fix(Local): encode nextpage data as bas64 fix(Local): encode nextpage data as base64 Mar 25, 2025
@FineFindus FineFindus force-pushed the fix/local-channel-continuations branch from f2e87b0 to a9a5485 Compare March 25, 2025 20:25
Fixes an issue, with local mode enabled, users where unable to
continously load channel data.
This was caused by the channel nextpage data being stored as a JVM
identifier (the default byte array .toString behaviour), rather than the
expected base64 encoded string.

Closes: libre-tube#7240
@FineFindus FineFindus force-pushed the fix/local-channel-continuations branch from a9a5485 to 3bf5fe2 Compare March 25, 2025 20:32
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating this!

@Bnyro Bnyro merged commit 1a8ab78 into libre-tube:master Mar 26, 2025
2 of 3 checks passed
@FineFindus FineFindus deleted the fix/local-channel-continuations branch March 26, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Channel content does not load when scrolling up with "Full local Mode"

2 participants