feat(LocalFeedRepository): filter members only videos #7113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
That makes sense, yes. There shouldn't be that many paid videos, so it likely won't make much of a difference in storage space used to the end user. |
3 tasks
Collaborator
Author
|
I've been thinking about this a bit over the last few days, and I don't think it's possible/a good idea to save them, as there are some channels that will first upload a video as a members-only video, and only later set it to public for all (á la early access). This could lead to videos not being shown at all or being shown late. In both cases, users would miss out on videos. |
Member
That's a valid argument, I agree. |
FineFindus
added a commit
to FineFindus/LibreTube
that referenced
this pull request
Apr 9, 2025
Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now it just contains a fix for working with newer YT player versions and checks if a video is avialable. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube#7113
FineFindus
added a commit
to FineFindus/LibreTube
that referenced
this pull request
Apr 9, 2025
Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now, it just contains a fix for working with newer YT player versions and checks if a video is available. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube#7113 Ref: https://github.com/libre-tube/NewPipeExtractor
FineFindus
force-pushed
the
feat/filter-members-videos
branch
2 times, most recently
from
1817502 to
f9edc56
Compare
Collaborator
Author
|
As we now include the required NewPipeExtractor API in our extractor fork, we can merge this as well. However, it should be noted that it is absolutely possible that the upstream PR will have API-breaking changes before being merged (as it already did once), so it may require a fix up in the future. |
reocat
pushed a commit
to reocat/OuterTune
that referenced
this pull request
Apr 15, 2025
Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now, it just contains a fix for working with newer YT player versions and checks if a video is available. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube/LibreTube#7113 Ref: https://github.com/libre-tube/NewPipeExtractor
YouTube inserts Members only videos into the normal video feed. As there not watchable without signing in, they clutter the feed, this filters them out before the're displayed. Ref: https://github.com/FineFindus/NewPipeExtractor/tree/feat/member-channeltab-info
Bnyro
force-pushed
the
feat/filter-members-videos
branch
from
f9edc56 to
5627a93
Compare
Bnyro
approved these changes
Apr 15, 2025
mostafaalagamy
added a commit
to mostafaalagamy/Metrolist
that referenced
this pull request
Apr 15, 2025
Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now, it just contains a fix for working with newer YT player versions and checks if a video is available. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube/LibreTube#7113 Ref: https://github.com/libre-tube/NewPipeExtractor Co-authored-by: reocat <[email protected]>
reocat
pushed a commit
to reocat/OuterTune
that referenced
this pull request
Apr 15, 2025
Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now, it just contains a fix for working with newer YT player versions and checks if a video is available. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube/LibreTube#7113 Ref: https://github.com/libre-tube/NewPipeExtractor
reocat
pushed a commit
to reocat/OuterTune
that referenced
this pull request
Apr 23, 2025
Switches from the official NewPipeExtractor versions to a soft fork, allowing fixes and other improvements that have not yet been merged upstream. For now, it just contains a fix for working with newer YT player versions and checks if a video is available. Ref: TeamNewPipe/NewPipeExtractor#1290 Ref: libre-tube/LibreTube#7113 Ref: https://github.com/libre-tube/NewPipeExtractor
FineFindus
added a commit
to FineFindus/LibreTube
that referenced
this pull request
Sep 12, 2025
Applies the filtering of members-only videos to the channel page. As some channels upload a lot/mainly members-only content, it can be a hassle to find videos that are watchable in the app, which isn't a great user experience. Ref: libre-tube#7113
FineFindus
added a commit
that referenced
this pull request
Sep 12, 2025
Applies the filtering of members-only videos to the channel page. As some channels upload a lot/mainly members-only content, it can be a hassle to find videos that are watchable in the app, which isn't a great user experience. Ref: #7113
Bnyro
pushed a commit
to FineFindus/LibreTube
that referenced
this pull request
Sep 13, 2025
Applies the filtering of members-only videos to the channel page. As some channels upload a lot/mainly members-only content, it can be a hassle to find videos that are watchable in the app, which isn't a great user experience. Ref: libre-tube#7113
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YouTube has started to insert Members only videos into the normal video feed. As there not watchable without signing in, they only clutter the subscription feed.
This filters them out before they're displayed.
Requires TeamNewPipe/NewPipeExtractor#1280
This is still a draft as extractor PR is not yet merged. It might also make sense to still store the videos, so they can be used when deciding if a full channel fetch is needed?