fix: multiple recyclerview adapter regressions in SubscriptionsFragment #7085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Local pagination had been added in order to make it easier to adapt when TeamPiped/Piped#2353 is merged, though it currently doesn't seem like that'll happen in the near future. (This should have been implemented using |
Bnyro
approved these changes
Feb 10, 2025
Bnyro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7072
Fixes a crash when selecting a different subscription group and going back to the 'all' group
Be aware that this PR removes the local pagination. I think more performance improvements can be gained by making changes to the videos adapter compared to what the local pagination can achieve.