Skip to content

Conversation

@Pittvandewitt
Copy link
Contributor

This PR does several things to improve the code quality:

  • Perform navigation in the Fragment instead of the RV adapter
  • Pager now lives in the ViewModel and is emitted as LiveData. LiveData makes more sense because of the free lifecycle benefits you get compared to using Flow (by not having to use repeatOnLifecycle(Lifecycle.State.STARTED))

Other:

  • Smooth scrolling now works when pressing the scroll up button

comment.commentedTimeMillis?.let {
commentInfos.text = TextUtils.formatRelativeDate(it)
} ?: comment.commentedTime
commentInfos.text = comment.commentedTime
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please undo that line, perhaps you accidentally changed it on rebase

@Bnyro Bnyro force-pushed the refactor/comments branch from 12e4c58 to 3999a26 Compare October 10, 2025 16:54
Copy link
Member

@Bnyro Bnyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Bnyro Bnyro force-pushed the refactor/comments branch from 3999a26 to 6ee1787 Compare October 10, 2025 16:54
@Bnyro Bnyro merged commit 428444e into libre-tube:master Oct 10, 2025
3 checks passed
@Pittvandewitt Pittvandewitt deleted the refactor/comments branch October 10, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants