refactor: simplify add to playlist dialog #7074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efactor/add-to-playlist # Conflicts: # app/src/main/java/com/github/libretube/ui/dialogs/AddToPlaylistDialog.kt # app/src/main/java/com/github/libretube/ui/models/PlaylistViewModel.kt
Bnyro
reviewed
Feb 10, 2025
app/src/main/java/com/github/libretube/ui/dialogs/AddToPlaylistDialog.kt
Outdated
Show resolved
Hide resolved
Bnyro
reviewed
Feb 15, 2025
| } | ||
| } | ||
|
|
||
| fun onPostiveButtonClick(playlistIndex: Int) { |
There was a problem hiding this comment.
nit: this should probably be called something like addToPlaylistAtIndex instead, onPositiveButtonClick is not that descriptive.
Bnyro
force-pushed
the
refactor/add-to-playlist
branch
from
8dba201 to
6cfec07
Compare
Bnyro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does several things to improve the code quality: