-
-
Notifications
You must be signed in to change notification settings - Fork 522
Use default animations #7053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default animations #7053
Conversation
|
I'm on Android 15, and with these changes the predictive back animations between fragments are completely gone on my device. Activity animations still work, so it's certainly not a general predictive back issue but rather specific to this PR. I don't have a clue why things don't work the same as in the screen recording you shared on my end 🤷♂️ |
|
I ran the code changes on real devices running Android 15 and 16, both working as expected. It also works using an emulator. Maybe Android Studio is using an old cache in your case? Attached an apk built from this branch to double check |
Yes, even with a clean install, I tested the apk you provided. @FineFindus if you have time and motiviation, could you please test this as well on a real device that supports predictive back gestures? I'm asking because I remember that you've been looking into the predictive player back animation recently and thus likely have a device to test it. (No pressure though!) |
|
Tested with the attached apk, works fine for me (though I noticed that the Watch History/Downloads pages no longer have any back animation). |
Any chance you have set animation scale to off in your developer settings?
Animations added |
Use default animations
a84fed8 to
84b34ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I switched to a different ROM and it works perfectly now. Thank you!
This PR reverts to the default animations now that the NavHost is using them. This results in somewhat better predictive back navigation. It doesn't yet use the material3 recommended animation patterns, but that is for a future commit. Before those animations can be implemented, a lot needs to be changed to make sure all data is loaded before the animation starts. (Using
Fragment.postponeEnterTransitionandFragment.startPostponedEnterTransition)closes #6973