fix(SubscriptionsFragment): update lastFeedWatchedTime to latest video upload in feed #7009
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FineFindus
force-pushed
the
fix/all-caught-up-local
branch
3 times, most recently
from
6de9613 to
e0b17ac
Compare
With the introduction of the local feed extraction, which only refreshes the feed naturally once a day, it is possible for the user to update the `lastFeedWatchedTime`, but not fetch the feed itself, leading to a disconnect between both values. When the feed is then later on refreshed, the caught-up-indicator is only displayed for the videos since the last app open, and not all new videos since the last refresh.
FineFindus
force-pushed
the
fix/all-caught-up-local
branch
from
e0b17ac to
54835c9
Compare
Bnyro
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of the local feed extraction, which only refreshes the feed naturally once a day, it is possible for the user to update the
lastFeedWatchedTime, but not fetch the feed itself, leading to a disconnect between both values.When the feed is then later on refreshed, the caught-up-indicator is only displayed for the videos since the last app open, and not all new videos since the last refresh.