Skip to content

Fix back navigation from comment replies #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 15, 2025
Merged

Fix back navigation from comment replies #6954

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51e6f44
Pop from replies to comments instead of closing comments sheet
Pittvandewitt Jan 14, 2025
fa788d7
Pop from replies to comments instead of closing comments sheet
Pittvandewitt Jan 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions app/src/main/java/com/github/libretube/ui/sheets/CommentsSheet.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.activity.ComponentDialog
import androidx.activity.addCallback
import androidx.core.view.isVisible
import androidx.fragment.app.activityViewModels
import androidx.fragment.app.commit
Expand All @@ -20,6 +22,14 @@ class CommentsSheet : ExpandablePlayerSheet() {

private val commonPlayerViewModel: CommonPlayerViewModel by activityViewModels()

private val backPressedCallback by lazy(LazyThreadSafetyMode.NONE) {
(dialog as ComponentDialog?)?.onBackPressedDispatcher?.addCallback(owner = viewLifecycleOwner, enabled = false) {
if (childFragmentManager.backStackEntryCount > 0) {
childFragmentManager.popBackStack()
}
}
}

override fun onCreateView(
inflater: LayoutInflater,
container: ViewGroup?,
Expand Down Expand Up @@ -70,6 +80,7 @@ class CommentsSheet : ExpandablePlayerSheet() {
fun updateFragmentInfo(showBackButton: Boolean, title: String) {
binding.btnBack.isVisible = showBackButton
binding.commentsTitle.text = title
backPressedCallback?.isEnabled = showBackButton
}

companion object {
Expand Down
Loading