Skip to content

fix: play local video version dialog hidden if autofullscreen enabled #6936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2025
Merged

fix: play local video version dialog hidden if autofullscreen enabled #6936

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,11 @@ class PlayerFragment : Fragment(), OnlinePlayerOptions {
}

if (localDownloadVersion != null && createNewSession) {
childFragmentManager.setFragmentResultListener(
// the dialog must also be visible when in fullscreen, thus we need to use the activity's
// fragment manager and not the one from [PlayerFragment]
val fragmentManager = requireActivity().supportFragmentManager

fragmentManager.setFragmentResultListener(
PlayOfflineDialog.PLAY_OFFLINE_DIALOG_REQUEST_KEY, viewLifecycleOwner
) { _, bundle ->
if (bundle.getBoolean(IntentData.isPlayingOffline)) {
Expand All @@ -459,7 +463,7 @@ class PlayerFragment : Fragment(), OnlinePlayerOptions {
IntentData.videoTitle to localDownloadVersion.download.title,
IntentData.downloadInfo to downloadInfo
)
}.show(childFragmentManager, null)
}.show(fragmentManager, null)
} else {
attachToPlayerService(playerData, createNewSession)
}
Expand Down
Loading