Skip to content

fix: recent player UI regressions #6781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix: recent player UI regressions #6781

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 13 additions & 16 deletions app/src/main/java/com/github/libretube/ui/fragments/PlayerFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,7 +400,6 @@ class PlayerFragment : Fragment(), OnlinePlayerOptions {

initializeTransitionLayout()
initializeOnClickActions()
initializePlayerView()

if (PlayerHelper.autoFullscreenEnabled && resources.configuration.orientation == Configuration.ORIENTATION_LANDSCAPE) {
setFullscreen()
Expand Down Expand Up @@ -464,21 +463,6 @@ class PlayerFragment : Fragment(), OnlinePlayerOptions {
}
}

private fun initializePlayerView() {
// initialize the player view actions
binding.player.initialize(
doubleTapOverlayBinding,
playerGestureControlsViewBinding,
chaptersViewModel
)
binding.player.initPlayerOptions(
viewModel,
commonPlayerViewModel,
viewLifecycleOwner,
this
)
}

@SuppressLint("ClickableViewAccessibility")
private fun initializeTransitionLayout() {
mainActivity.binding.container.isVisible = true
Expand Down Expand Up @@ -982,6 +966,19 @@ class PlayerFragment : Fragment(), OnlinePlayerOptions {
player = playerController
}

// initialize the player view actions
binding.player.initialize(
doubleTapOverlayBinding,
playerGestureControlsViewBinding,
chaptersViewModel
)
binding.player.initPlayerOptions(
viewModel,
commonPlayerViewModel,
viewLifecycleOwner,
this
)

updatePlayerView()

if (binding.playerMotionLayout.progress != 1.0f) {
Expand Down
Loading