Skip to content

refactor: add donation button to action menu #6386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 23, 2024
Merged

refactor: add donation button to action menu #6386

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/src/main/java/com/github/libretube/helpers/IntentHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@ object IntentHelper {
}
}

fun openLinkFromHref(context: Context, fragmentManager: FragmentManager, link: String) {
fun openLinkFromHref(context: Context, fragmentManager: FragmentManager, link: String, forceDefaultOpen: Boolean = false) {
val resolveInfoList = getResolveInfo(context, link)

if (resolveInfoList.isEmpty()) {
if (resolveInfoList.isEmpty() || forceDefaultOpen) {
try {
context.startActivity(getResolveIntent(link))
} catch (e: Exception) {
Expand Down
2 changes: 1 addition & 1 deletion app/src/main/java/com/github/libretube/ui/activities/AboutActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ class AboutActivity : BaseActivity() {
}

companion object {
private const val DONATE_URL = "https://github.com/libre-tube/LibreTube#donate"
const val DONATE_URL = "https://github.com/libre-tube/LibreTube#donate"
private const val WEBSITE_URL = "https://libretube.dev"
private const val GITHUB_URL = "https://github.com/libre-tube/LibreTube"
private const val PIPED_GITHUB_URL = "https://github.com/TeamPiped/Piped"
Expand Down
10 changes: 10 additions & 0 deletions app/src/main/java/com/github/libretube/ui/activities/MainActivity.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,6 +441,16 @@ class MainActivity : BaseActivity() {
true
}

R.id.action_donate -> {
IntentHelper.openLinkFromHref(
this,
supportFragmentManager,
AboutActivity.DONATE_URL,
forceDefaultOpen = true
)
true
}

else -> super.onOptionsItemSelected(item)
}
}
Expand Down
5 changes: 5 additions & 0 deletions app/src/main/res/menu/action_bar.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@
android:title="@string/help"
app:showAsAction="never" />

<item
android:id="@+id/action_donate"
android:title="@string/donate"
app:showAsAction="never" />

<item
android:id="@+id/action_about"
android:title="@string/about"
Expand Down