Support other repos using the multidim interop tests#99
Conversation
MarcoPolo
force-pushed
the
marco/wo-testground-opts
branch
from
833f651 to
a644753
Compare
|
tagging either @mxinden or @marten-seemann for review please :) |
| @@ -1,82 +0,0 @@ | |||
| name: start testground | |||
🚀 |
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Steps and code looks good to me. That said, I am not a GitHub action expert. I would assume Laurent and Piotr would be better as reviewers.
@jxs would you mind doing the changes of libp2p/go-libp2p#1991 for rust-libp2p?
@MarcoPolo I don't have an opinion on whether to block on libp2p/go-libp2p#1991 in rust-libp2p, or merge early here.
Great to see this happening. Thanks @MarcoPolo.
|
@galargh do you mind reviewing the GitHub workflow here? |
galargh
left a comment
galargh
left a comment
There was a problem hiding this comment.
I reviewed .github/workflows/run-testplans.yml only. One note on download-artifact usage. Otherwise, looks good.
| - uses: actions/download-artifact@v3 | ||
| if: ${{ inputs.extra-versions != '' }} | ||
| with: | ||
| name: ${{ inputs.extra-versions }} | ||
| path: /tmp/extra-versions | ||
| - uses: actions/download-artifact@v3 | ||
| if: ${{ inputs.image-tar != '' }} | ||
| with: | ||
| name: ${{ inputs.image-tar }} | ||
| path: /tmp/images/ |
There was a problem hiding this comment.
Just an FYI, these can only download artifacts from the same workflow run.
If you want to share artifacts between builds, you could use gh run download from GH CLI. We use it in GitHub Management for example, https://github.com/protocol/github-mgmt-template/blob/master/.github/workflows/apply.yml#L93-L97 (here, we get the most recent artifact with a given name that was uploaded by one of the repos workflows).
There was a problem hiding this comment.
Cool tip! Not needed for this PR, but I can imagine it being useful in other cases. I guess you have to keep in mind the 90 day limit of artifacts.
Currently, we can't merge any PRs until this is fixed. See for example: libp2p/rust-libp2p#3324 |
Update required rust-libp2p workflows to remove the stale interoperability tests. Addresses libp2p/test-plans#99 (comment)
* Support running interop workflow from other repos * A bit of shuffling and cleanup
5 participants
Features:
How to use this with other repos:
needs) the previous job. And pass in the proper input parameters. ExampleExample run that tests across versions and impl for go-libp2p-head: https://github.com/libp2p/go-libp2p/actions/runs/3894748269