Add gossip interop tests for jvm-libp2p#838
Open
lucassaldanha wants to merge 5 commits intolibp2p:masterfrom
Open
Add gossip interop tests for jvm-libp2p#838lucassaldanha wants to merge 5 commits intolibp2p:masterfrom
lucassaldanha wants to merge 5 commits intolibp2p:masterfrom
Conversation
Contributor
Author
|
@MarcoPolo I guess you would be the best person to review this one? |
Contributor
|
Thank you @lucassaldanha. Happy to have jvm-libp2p here. Looks like there's an interop issue between jvm and other implementations. Could you take a look? You can see the failure with these commands: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding jvm-libp2p latest stable version to gossip tests. Followed instructions from https://github.com/libp2p/test-plans/blob/master/gossipsub-interop/test-specs/implementation.md.