Update for rust-libp2p 0.49 release

[thomaseizinger]

I am not sure if I did all of this right. I was a bit confused as to why there is seemingly so much duplication between the various toml files and whether they all need updating or not.

Hoping that CI here will tell me whether this works :D

Resolves #59.

[thomaseizinger]

I don't quite understand how this works. Are we properly isolating the builds for the various versions so the features are not conflicting with each other? I can't figure out how to tell testground that it should use one feature set for one version and another for another version.

Without tesground, the way I'd do this is by having a matrix in GitHub actions such that the builds are isolated. The approach of having a single manifest file with multiple dependencies seems odd to me. We might just need to accept the duplication between multiple instances of the rust ping composition where each crate has its own dependency and therefore its own buildgraph. Once it is built for one version of rust-libp2p, it shouldn't need touching again unless the testground Rust crate changes so the maintenance effort doesn't seem to be too bad?

Anyway, just my 2c on interacting with this for the first time :)

[thomaseizinger]

Okay, I think I found the curlpit. The Cargo.lock wasn't updated 🙄

I still think the way ping/rust is currently structured is a bit dodgy 😅

pub mod libp2p {
    #[cfg(all(feature = "libp2pmaster",))]
    pub use libp2pmaster::*;

    #[cfg(all(feature = "libp2pv0480",))]
    pub use libp2pv0480::*;

    #[cfg(all(feature = "libp2pv0470",))]
    pub use libp2pv0470::*;

    #[cfg(all(feature = "libp2pv0460",))]
    pub use libp2pv0460::*;

    #[cfg(all(feature = "libp2pv0450",))]
    pub use libp2pv0450::*;

    #[cfg(all(feature = "libp2pv0440",))]
    pub use libp2pv0440::*;
}

This is just asking to break with changes like libp2p/rust-libp2p#2859. Here we deprecated the with_keep_alive builder on the ping protocol. The new way is to compose it with a keep_alive::Behaviour but that only exists from 0.49 onwards.

I think we should split ping/rust into one crate per libp2p version and try to cut down the duplication through other means. We can probably create a workspace local crate with some shared functionality. I reckon we are going to need that anyway once we test more things in testground.

[thomaseizinger]

I think I actually got it now haha

Seems to be passing.

[mxinden]

Thanks for the work here @thomaseizinger! Impressive how fast you got started on this.

I added 06b6527. If I am not mistaken, tcp and async-std and dns were missing. As far as I can tell, CI was still green as we don't test the git ref path here. As we are not triggering the workflows from rust-libp2p or go-libp2p, the workflow doesn't know which git reference to use.

[mxinden]

🙏

[thomaseizinger]

I added 06b6527. If I am not mistaken, tcp and async-std and dns were missing.

I had moved them to the actual dependency that is declared in Cargo.toml but I guess that bit is actually sed-ed out?

[mxinden]

I added 06b6527. If I am not mistaken, tcp and async-std and dns were missing.

I had moved them to the actual dependency that is declared in Cargo.toml but I guess that bit is actually sed-ed out?

That is my understanding, yes.

[laurentsenta]

Nice, thanks for the fix,
Details on the sed: #26 (comment)
(we can't use cargo replace with feature flags).