refactor baseline pubsub test out of private repo#6
Merged
yusefnapora merged 7 commits intolibp2p:masterfrom May 15, 2020
yusefnapora:feat/pubsub-baseline
Merged
refactor baseline pubsub test out of private repo#6yusefnapora merged 7 commits intolibp2p:masterfrom yusefnapora:feat/pubsub-baseline
yusefnapora merged 7 commits intolibp2p:masterfrom
yusefnapora:feat/pubsub-baseline
Conversation
|
@yusefnapora access should be fixed, I added the |
daviddias
reviewed
May 12, 2020
Member
daviddias
left a comment
daviddias
left a comment
There was a problem hiding this comment.
Overall looks where we want to be. I recommend not overloading users with non relevant info (i.e. attack code or mentions of sybils)
Contributor
Author
|
I've tested this out on our jupyterhub instance using the k8s runner. Everything seems to work as expected, but it was taking a fairly long time to get all pods in the Ready state - about 2.5 minutes for 1k nodes. I increased the setup time in the saved configs to 3 minutes, since if it's lower than the actual time needed to get into the running state, the test results get skewed. |
codemaestro64
pushed a commit
to codemaestro64/test-plans
that referenced
this pull request
Oct 28, 2025
* refactor baseline test out of private repo * rm references to attackers * fix default plan name & add widget to override * add configs for local runners * update runner notebook intro text * fix build tags * increase setup time in saved configs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in the baseline evaluation plan from the private repo we've been using to evaluate gossipsub under attack.
We're planning to publish that code soon also, but for now this just has the "honest" node type included.
cc @daviddias @vyzo @dirkmc @nonsense
BTW, if anyone wants to give me write access to this repo, that would be sweet 😄