ping/_composition: use latest release in interop-latest#37
ping/_composition: use latest release in interop-latest#37laurentsenta merged 1 commit intomasterfrom
Conversation
be1774e to
7f0d044
Compare
7f0d044 to
fc7a0e0
Compare
|
See related discussion in libp2p/rust-libp2p#2835 I still think we could test But I want to merge interop as soon as possible in rust and make sure we don't break go-libp2p, so let's have a follow-up discussion when interop test is running everywhere! |
marten-seemann
left a comment
There was a problem hiding this comment.
Not sure I can review this, I don't understand what's going on in this TOML file.
|
|
||
| {{ with (load_resource "./go.toml") }} | ||
| {{ with .master }} | ||
| {{ with (index .groups 0) }} |
There was a problem hiding this comment.
@marten-seemann No worries, I requested your review regarding the feature itself,
nothing much to see in the code, quick overview:
- we use go templates to simplify maintenance,
- with
load_resourcewe load https://github.com/libp2p/test-plans/blob/master/ping/_compositions/go.toml in the template.
This PR replaces the use of the master version with the latest release registered in .groups (loaded from the go.toml file)
mxinden
left a comment
There was a problem hiding this comment.
From what I can tell, this looks good to me.
Update the interop (latest) tests so that we build & test:
(before we would test against
masterbranch for each of these projects).