Skip to content

ping/_composition: use latest release in interop-latest#37

Merged
laurentsenta merged 1 commit intomasterfrom
feat/interop-latest-tests-against-releases
Sep 6, 2022
Merged

ping/_composition: use latest release in interop-latest#37
laurentsenta merged 1 commit intomasterfrom
feat/interop-latest-tests-against-releases

Conversation

@laurentsenta
Copy link
Copy Markdown
Collaborator

@laurentsenta laurentsenta commented Sep 5, 2022

Update the interop (latest) tests so that we build & test:

  • latest released go version
  • latest released rust version
  • current branch (rust or go)

(before we would test against master branch for each of these projects).

@laurentsenta laurentsenta marked this pull request as draft September 5, 2022 13:37
@laurentsenta laurentsenta force-pushed the feat/interop-latest-tests-against-releases branch 2 times, most recently from be1774e to 7f0d044 Compare September 5, 2022 14:17
@laurentsenta laurentsenta force-pushed the feat/interop-latest-tests-against-releases branch from 7f0d044 to fc7a0e0 Compare September 6, 2022 08:05
@laurentsenta laurentsenta marked this pull request as ready for review September 6, 2022 08:31
@laurentsenta
Copy link
Copy Markdown
Collaborator Author

@mxinden @marten-seemann

See related discussion in libp2p/rust-libp2p#2835

I still think we could test master branch together. As long as the go and rust libraries run the tests on every PR, testing master would let us test the interop for new features.

But I want to merge interop as soon as possible in rust and make sure we don't break go-libp2p, so let's have a follow-up discussion when interop test is running everywhere!

Copy link
Copy Markdown
Contributor

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I can review this, I don't understand what's going on in this TOML file.


{{ with (load_resource "./go.toml") }}
{{ with .master }}
{{ with (index .groups 0) }}
Copy link
Copy Markdown
Collaborator Author

@laurentsenta laurentsenta Sep 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marten-seemann No worries, I requested your review regarding the feature itself,

nothing much to see in the code, quick overview:

This PR replaces the use of the master version with the latest release registered in .groups (loaded from the go.toml file)

Copy link
Copy Markdown
Member

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what I can tell, this looks good to me.

@laurentsenta
Copy link
Copy Markdown
Collaborator Author

@laurentsenta laurentsenta merged commit 0d23871 into master Sep 6, 2022
@laurentsenta laurentsenta deleted the feat/interop-latest-tests-against-releases branch September 6, 2022 15:34
codemaestro64 pushed a commit to codemaestro64/test-plans that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants