ping/_composition/go.toml: disable go custom & master branches#30
ping/_composition/go.toml: disable go custom & master branches#30laurentsenta wants to merge 1 commit intolibp2p:masterfrom
Conversation
|
@mxinden @marten-seemann are we fine with this? |
|
This would be a sad outcome. I didn't mean to break our interop testing story when I disabled the tests, but the flakiness was holding us back from making progress. Do we have any timeline for a more stable version of the test setup? |
|
@marten-seemann It really depends on your definition of "good enough" (#29 (comment)) If you're fine with ~25 min of CI time (#29), we add retries and re-enable the go cross versions tests by tomorrow. If you need ~20 min of CI time, we add retries, and improve testground setup (should take less than a week, testground/testground#1371), then re-enable the go cross versions tests. If you need less, we implement caching with #31 (should take a week or two) then improve testground setup (a week). We might get the cross-version AND cross-implementation testing below the 10 minutes bar. |
|
By the way, it's not ideal, but I think it's fine to disable the go master test if it means we can get some workload on the rust side. It will help with stability work more than if we're not running rust at all. |
|
Replaced by #32 |
We disabled interop tests in go-libp2p which means that the go-libp2p team might break the interoperability testing at any time.
That's a problem when it comes to interoperability testing: if we enable interop testing in rust, maintainers will experience random breakage in the CI because of the other repo. We can only play catch-up with the go-side until we re-enable the interop tests there.
This PR disables go's
masterandcustomtests until we fix the stability / caching issues and reenable the tests in go-libp2p.Related issues & PR
current go status
The tests started breaking after we moved go-libp2p-core into go-libp2p/core. It breaks every versions at the moment (work in progress branch).