feat(.github/perf): reference metrics dashboard#297
Merged
Conversation
mxinden
reviewed
Sep 4, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Way better! Small comment in case you know a quick-fix.
| git add benchmark-results.json | ||
| git commit -m "perf: update benchmark results" | ||
| git push | ||
| gh pr comment --body "See new metrics at https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=$(git rev-parse HEAD)" || true |
Member
There was a problem hiding this comment.
Small nit: I am not sure $(git rev-parse HEAD) would be URL encoded. E.g. a branch of system/subsystem would not work here, right?
Contributor
There was a problem hiding this comment.
afaik git rev-parse HEAD always outputs a commit hash
Member
Author
There was a problem hiding this comment.
afaik
git rev-parse HEADalways outputs a commit hash
👍
I also checked and the dashboard works fine with hashes. E.g. https://observablehq.com/@libp2p-workspace/performance-dashboard?branch=cb2db89d5ead60942e49f34bb6b0a3db83de26e3#branch
Member
There was a problem hiding this comment.
My bad. Yes. That makes sense. Thanks!
mxinden
approved these changes
Sep 4, 2023
codemaestro64
pushed a commit
to codemaestro64/test-plans
that referenced
this pull request
Oct 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #296 which ties the PR commenting to the perf job instead.