Skip to content

feat(interop): add rust-libp2p chromium WASM WebTransport#217

Merged
mxinden merged 3 commits intomasterfrom
interop-rust-chromium
Jul 7, 2023
Merged

feat(interop): add rust-libp2p chromium WASM WebTransport#217
mxinden merged 3 commits intomasterfrom
interop-rust-chromium

Conversation

@mxinden
Copy link
Member

@mxinden mxinden commented Jul 3, 2023

Introduced in rust-libp2p with libp2p/rust-libp2p#4015.

@mxinden mxinden changed the title feat(interop/rust-chromium): add rust-libp2p chromium WASM WebTransport feat(interop): add rust-libp2p chromium WASM WebTransport Jul 3, 2023
Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mxinden ! Still can't believe we have tests for this now, so exciting!

Looking forward to extending support for this for WebSocket and WebRTC!

@mxinden
Copy link
Member Author

mxinden commented Jul 3, 2023

Still can't believe we have tests for this now, so exciting!

Same. //CC @zvolin.

@mxinden
Copy link
Member Author

mxinden commented Jul 3, 2023

Note that rust-libp2p WebTransport tests are not triggered yet. Need to investigate. Maybe related to #218.

@zvolin
Copy link

zvolin commented Jul 3, 2023

Excited too :) they indeed look great after your reviews

@thomaseizinger
Copy link
Contributor

Note that rust-libp2p WebTransport tests are not triggered yet. Need to investigate. Maybe related to #218.

Perhaps #210 is related?

@mxinden
Copy link
Member Author

mxinden commented Jul 5, 2023

Note that rust-libp2p WebTransport tests are not triggered yet. Need to investigate. Maybe related to #218.

Perhaps #210 is related?

Thank you @thomaseizinger! That helped.

Proposed fix in #219.

@mxinden mxinden marked this pull request as ready for review July 6, 2023 11:47
@mxinden
Copy link
Member Author

mxinden commented Jul 6, 2023

image

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yey!

@mxinden mxinden merged commit ce83afc into master Jul 7, 2023
@mxinden mxinden deleted the interop-rust-chromium branch July 7, 2023 12:37
@mxinden
Copy link
Member Author

mxinden commented Jul 7, 2023

@MarcoPolo since you set-up the js-libp2p part, let me know in case you want any follow-ups.

codemaestro64 pushed a commit to codemaestro64/test-plans that referenced this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants