Conversation
Contributor
|
@MarcoPolo : is this unblocked now so can be moved out of draft and finished up? |
Contributor
Author
|
Yup! I'll circle back to this today |
Contributor
Author
|
This is ready for review. I changed the v0.24 Go implementation because it was easy and added a new js-libp2p v0.42 implementation with wss. After we merge this I'll backport the changes to other versions. @marten-seemann could you review the Go changes (should be quick). |
marten-seemann
approved these changes
Mar 4, 2023
28 tasks
codemaestro64
pushed a commit
to codemaestro64/test-plans
that referenced
this pull request
Oct 28, 2025
* Update playwright test * Update multiaddr * WIP: websocket testing in browser * Add v0.42 test * node-image.json * Revert js v0.41 changes * Update versions.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browsers can only dial secure websocket addresses. So this also changes one Go implementation to listen on a TLS+WS (WSS) address.
Blocked on: