Draft: support ping test for both NodeJS and Browser#102
Closed
GlenDC wants to merge 14 commits intolibp2p:masterfrom
Closed
Draft: support ping test for both NodeJS and Browser#102GlenDC wants to merge 14 commits intolibp2p:masterfrom
GlenDC wants to merge 14 commits intolibp2p:masterfrom
Conversation
added 14 commits
January 11, 2023 12:03
TODO: - docker - browser runtime
Contributor
Author
|
Replaced by #104, as it makes more sense to go for the aegir based approach. More sense as that is also the testing strategy chosen for all other js-libp2p codebase(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A previous (already merged) PR added support for the new wo-testground way of going for the ping test case for the JS Runtime. This was however only so for NodeJS.
This PR extends that support to Browser.
NOTE: for now this PR is broken as the Docker support is still to be fixed with the new dual support.
Once we agree on the currently taken approach for the dual support (NodeJS + Browser) I'll finish of the docker support,
as part of this PR.
Goal is to have the same test file for both NodeJS and Browser, and to be able to avoid having to bother for our JS tests to write anything non-test specific (e.g. setup browser).