identify: add a sequence number to the Identify protobuf #502
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxinden
reviewed
Jan 4, 2023
MarcoPolo
requested changes
Jan 7, 2023
Contributor
MarcoPolo
left a comment
MarcoPolo
left a comment
There was a problem hiding this comment.
Once the wording change is in, request a review and I'll approve
Contributor
Author
|
Sorry for the delay, I just added the paragraph as suggested. |
MarcoPolo
approved these changes
May 22, 2023
Member
|
This PR has the sufficient approvals, @marten-seemann can this be merged? |
Contributor
Author
|
@p-shahi Maybe, that's for you guys to decide now... Looking back at the text, I'm not sure I like the fact that this is cross-connection. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #501.