src/lib: Default to WindowUpdateMode::OnRead

[mxinden]

Default to WindowUpdateMode::OnRead, thus enabling full Yamux
flow-control, exercising back pressure on senders, preventing stream
resets due to reaching the buffer limit.

See the WindowUpdateMode documentation for details, especially the
section on deadlocking when sending data larger than the receivers
window.

This would prevent surprises like libp2p/rust-libp2p#2089.

[AgeManning]

I'm not very familiar with the intricacies here.

It does seem like in most cases the deadlock risk is unlikely compared the benefits in setting this to default, so makes sense to me.

[mxinden]

//CC @ec2 and @olibearo as you are currently using YamuxConfig::default().

https://github.com/ChainSafe/forest/blob/main/node/forest_libp2p/src/service.rs#L381

//CC @koivunej for rust-ipfs:

https://github.com/rs-ipfs/rust-ipfs/blob/master/src/p2p/transport.rs#L31

//CC @dvc94ch for ipfs-embed:

https://github.com/ipfs-rust/ipfs-embed/blob/master/src/net/mod.rs#L93

[koivunej]

Thanks for the ping @mxinden! Per your explanation this sounds very much a reasonable default but I don't have knowledge on yamux internals except for what I've learned by reading random issues.

[dvc94ch]

Seems ok. It's not a breaking change as it only affects the receiver behavior if I understand correctly. Thanks!