feat(gossipsub): feature gate metrics related code #6020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
force-pushed
the
refactor-scoring
branch
2 times, most recently
from
44817d7 to
ad513bc
Compare
dariusc93
reviewed
May 12, 2025
replace Option<PeerScore> with PeerScoreState to allow to ease that move
by returning the penalties in the score report insteadw
Co-authored-by: Darius Clark <[email protected]>
elenaf9
reviewed
May 15, 2025
Member
elenaf9
left a comment
elenaf9
left a comment
There was a problem hiding this comment.
I like the refactor, I think it improves readability.
I don't really have an opinion on whether we should/ need to feature-gate the metrics code, but this PR solves it quite nicely without impacting readability too much.
jxs
commented
May 15, 2025
Member
Author
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Thanks Elena! Addressed your comments, if it's conforming feel free to approve and send-it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
while refactoring scoring for libp2p/specs#664 I recalled #5711 and so this PR changed scope from a refactor to a feature.
Per commit review is suggested for an easier experience.
CC @drHuangMHT