fix(websocket): backport quicksink panic fix

[jxs]

Description

Backport #5482's c19c140 to v0.52

[jxs]

@lexnv since since is broken, can you test this with [patch]? If everything is accordingly I'll then release

[lexnv]

@jxs will test this right away, thanks! Will come back with a triaging output

[lexnv]

Thinking about it, would cherry-picking 003bb0b instead make things easier here?

I've initially created that patch fix for an easier release process, and has been in-depth tested 😄
Then we can have a release with passing CIs and tests, what do you think? @jxs @dariusc93

[jxs]

Thinking about it, would cherry-picking 003bb0b instead make things easier here?

I've initially created that patch fix for an easier release process, and has been in-depth tested 😄 Then we can have a release with passing CIs and tests, what do you think? @jxs @dariusc93

the problem with the CI doesn't relate with this PR, different CI tasks became broken due to multiple reasons that were addressed with other PR's, which could be cherry-picked into this commit.
I assumed you also tested in depth #5482 that's why you accepted the proposed patch, was that not the case?

[lexnv]

The fix looks stable, attaching triaging:

Count      | Level      | Triage report
2224       | warn       | Notification block pinning limit reached. Unpinning block with hash = .*
26         | warn       | Report .*: .* to .*. Reason: .*. Banned, disconnecting. ( Not requested block data. Banned, disconnecting.    )
13         | warn       | Report .*: .* to .*. Reason: .*. Banned, disconnecting. ( Unsupported protocol. Banned, disconnecting.    )
9          | warn       | Report .*: .* to .*. Reason: .*. Banned, disconnecting. ( Same block request multiple times. Banned, disconnecting.    )
1          | warn       | ❌ Error while dialing .*: .*
1          | warn       | Report .*: .* to .*. Reason: .*. Banned, disconnecting. ( Grandpa: Past message. Banned, disconnecting.    )
1          | warn       | Report .*: .* to .*. Reason: .*. Banned, disconnecting. ( Grandpa: Duplicate neighbor message without grace period. Banned, disconnecting.    )

The node also looks healthy from the metrics perspective.

I was a bit scared about the libp2p CI failing, good to know its not about this backport. Indeed I tested both patches :D
Thanks a lot @jxs 🙏

[jxs]

The fix looks stable, attaching triaging:

Count      | Level      | Triage report
2224       | warn       | Notification block pinning limit reached. Unpinning block with hash = .*
26         | warn       | Report .*: .* to .*. Reason: .*. Banned, disconnecting. ( Not requested block data. Banned, disconnecting.    )
13         | warn       | Report .*: .* to .*. Reason: .*. Banned, disconnecting. ( Unsupported protocol. Banned, disconnecting.    )
9          | warn       | Report .*: .* to .*. Reason: .*. Banned, disconnecting. ( Same block request multiple times. Banned, disconnecting.    )
1          | warn       | ❌ Error while dialing .*: .*
1          | warn       | Report .*: .* to .*. Reason: .*. Banned, disconnecting. ( Grandpa: Past message. Banned, disconnecting.    )
1          | warn       | Report .*: .* to .*. Reason: .*. Banned, disconnecting. ( Grandpa: Duplicate neighbor message without grace period. Banned, disconnecting.    )

The node also looks healthy from the metrics perspective.

I was a bit scared about the libp2p CI failing, good to know its not about this backport. Indeed I tested both patches :D Thanks a lot @jxs 🙏

awesome, thanks for running the tests! released 0.42.2