feat(kad): FIND_NODE for own peer id returns closest peers #5270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
changed the title
jxs
approved these changes
Mar 27, 2024
Member
jxs
left a comment
jxs
left a comment
There was a problem hiding this comment.
Thanks for this Gui LGTM, can you add a CHANGELOG.MD entry and version bump (since this is a breaking change)?
guillaumemichel
force-pushed
the
fix/findnode-self
branch
from
5f5888d to
307ec2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5269.
Notes & open questions
FIND_NODEresponse should not contain self nor the requester ID, but should never be empty if it has any other peers in the routing table.Change checklist