fix(kad): wake Handler after pushing into pending_messages#4961
Closed
stormshield-frb wants to merge 1 commit intolibp2p:masterfrom
Closed
fix(kad): wake Handler after pushing into pending_messages#4961stormshield-frb wants to merge 1 commit intolibp2p:masterfrom
Handler after pushing into pending_messages#4961stormshield-frb wants to merge 1 commit intolibp2p:masterfrom
Conversation
stormshield-frb
force-pushed
the
fix/pending-messages-might-be-not-detected
branch
from
21778f0 to
f6bc4e3
Compare
dariusc93
reviewed
Nov 29, 2023
Contributor
|
Finding all the bugs in my code @stormshield-frb ! 🙈 |
thomaseizinger
changed the title
pending_messages do not wake up Handler::pollHandler after pushing into pending_messages
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Great find!
I wonder if this is worth testing writing a test for although I am not sure how exactly we'd write one.
stormshield-frb
force-pushed
the
fix/pending-messages-might-be-not-detected
branch
2 times, most recently
from
6c2da35 to
cccf87b
Compare
stormshield-frb
force-pushed
the
fix/pending-messages-might-be-not-detected
branch
from
cccf87b to
77c734d
Compare
stormshield-frb
force-pushed
the
fix/pending-messages-might-be-not-detected
branch
from
77c734d to
d1e3ea7
Compare
Contributor
|
As per discussion in #4960, I think we can close this as not necessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #4960.
Notes & open questions
N/A
Change checklist