Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ jobs:
rust-version: [
# 1.72.0, # current stable
# beta,
nightly-2023-09-10
nightly-2023-11-26
Comment on lines 221 to +223
Copy link
Contributor

@thomaseizinger thomaseizinger Nov 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can actually go back to "stable" and "beta" here now that 1.74 is stable (which includes the [lints] feature). Mind changing this back to:

       1.74.0, # current stable
       beta

]
steps:
- uses: actions/checkout@v4
Expand Down
6 changes: 3 additions & 3 deletions muxers/mplex/src/io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,7 @@ where
// yield to give the current task a chance to read
// from the respective substreams.
if num_buffered == self.config.max_buffer_len {
cx.waker().clone().wake();
cx.waker().wake_by_ref();
return Poll::Pending;
}

Expand Down Expand Up @@ -456,7 +456,7 @@ where
// next frame for `id`, yield to give the current task
// a chance to read from the other substream(s).
if num_buffered == self.config.max_buffer_len {
cx.waker().clone().wake();
cx.waker().wake_by_ref();
return Poll::Pending;
}

Expand Down Expand Up @@ -663,7 +663,7 @@ where
connection=%self.id,
"No task to read from blocked stream. Waking current task."
);
cx.waker().clone().wake();
cx.waker().wake_by_ref();
} else if let Some(id) = stream_id {
// We woke some other task, but are still interested in
// reading `Data` frames from the current stream when unblocked.
Expand Down
2 changes: 1 addition & 1 deletion protocols/relay/src/behaviour/rate_limiter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ impl<Id: Eq + PartialEq + Hash + Clone> GenericRateLimiter<Id> {
// Note when used with a high number of buckets: This loop refills all the to-be-refilled
// buckets at once, thus potentially delaying the parent call to `try_next`.
loop {
match self.refill_schedule.get(0) {
match self.refill_schedule.front() {
// Only continue if (a) there is a bucket and (b) the bucket has not already been
// refilled recently.
Some((last_refill, _)) if now.duration_since(*last_refill) >= self.interval => {}
Expand Down