fix(swarm): don't emit NewExternalAddrCandidate on clients

[nazar-pc]

Description

Nodes without active listen addresses (aka "clients") still produce external address candidates via protocols such as identify through the observed address. Those are however guaranteed to be useless as not having any listeners means no other node can reach us.

Notes & open questions

There are a few more issues that this PR didn't fix (UDP: I now see that transports take care of this in their translation implementation):

• address translation is flawed, it doesn't take protocol into consideration, so it is possible to receive observed TCP address from identify and end up with UDP translated address (which in most cases will still be correct, but strictly speaking doesn't have to)
• this PR doesn't check that listener addresses which are present are in fact of the same protocol, mirroring address translation "behavior"

This PR could be potentially incorrect in case there are protocols where it is possible to have observed address without listener addresses, but I am not aware of such protocols and it would still be possible to work around that with user-level code.

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[thomaseizinger]

Thanks! This makes sense. I've left two comments.

[thomaseizinger]

@nazar-pc It seems there is a test-failure in libp2p-identify now.

[mergify]

This pull request has merge conflicts. Could you please resolve them @nazar-pc? 🙏

[mxinden]

Thanks

[mxinden]

@nazar-pc can you resolve the merge conflicts?

Approvals have been dismissed because the PR was updated after the send-it label was applied.

[mergify]

This pull request has merge conflicts. Could you please resolve them @nazar-pc? 🙏

[nazar-pc]

only_emits_address_candidate_once_per_connection test failed, but I'm not sure why would it from the code, looks like listen address should be present by then.

[drHuangMHT]

@thomaseizinger Stalled PR here.

[thomaseizinger]

only_emits_address_candidate_once_per_connection test failed, but I'm not sure why would it from the code, looks like listen address should be present by then.

The test is failing because swarm1 doesn't actually listen on any address. That is the exact check this PR implements :)

We will need to make swarm1 listen on something to bypass the if you are adding here!

[drHuangMHT]

Any chance we get this merged? ping @nazar-pc and @elenaf9 not that I want it but it is a nice-to-have small and simple fix