fix(swarm): implement ConnectionHandler::poll_close for combinators#4794
Merged
mergify[bot] merged 7 commits intolibp2p:masterfrom Nov 5, 2023
Merged
fix(swarm): implement ConnectionHandler::poll_close for combinators#4794mergify[bot] merged 7 commits intolibp2p:masterfrom
ConnectionHandler::poll_close for combinators#4794mergify[bot] merged 7 commits intolibp2p:masterfrom
Conversation
Follow-up to libp2p#4076. This is especially relevant since `libp2p-swarm-derive` uses `SelectConnectionHandler`.
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Oh nice catch!
Did this land in v0.52? I thought we only shipped this together with the removal of the handler field from the error?
thomaseizinger
changed the title
ConnectionHandler::poll_close for combinators
Contributor
|
@mxinden I fixed the compile errors and simplified some of the implementations by relying on the now documented requirement for |
Closed
mxinden
commented
Nov 4, 2023
Member
Author
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Requiring fuse like behavior sounds good to me.
Thank you for the additional commits.
Member
Author
|
Mind approving this pull request @thomaseizinger? |
Member
Author
I am probably mistaken. Let's ignore |
thomaseizinger
approved these changes
Nov 5, 2023
thomaseizinger
added
the
internal-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #4076.
This is especially relevant since
libp2p-swarm-deriveusesSelectConnectionHandler.Notes & open questions
@thomaseizinger once this is merged, should we backport it to v0.52?
Change checklist