fix(request-response): don't keep duplicate addresses (v0.52 backport)

[b-zee]

Backport of #4700 on v0.52 branch.

• fix: deduplicate autonat add_server addresses
• keep peers in HashSet instead of SmallVec
• change (&HashSet)::into_iter to equivalent iter

[b-zee]

@thomaseizinger Do I change the CHANGELOG too? I'm not too familiar with back porting and releases in this way.

[thomaseizinger]

@thomaseizinger Do I change the CHANGELOG too? I'm not too familiar with back porting and releases in this way.

Yes please. And a version bump!

[mxinden]

I would expect this is missing a version bump in the root Cargo.toml? Let's see what CI says.

[mxinden]

bump version in root Cargo.toml

Thanks!

[b-zee]

Think CI did indeed complain. Please hold my hand here, I mess up something each time with these patches. 😉

[mxinden]

I don't think the "Ensure manifest and changelog" failures for unrelated crates need to be fixed here. Taking a look now. Maybe @thomaseizinger has an idea right away.

[mxinden]

I don't think the "Ensure manifest and changelog" failures for unrelated crates need to be fixed here. Taking a look now. Maybe @thomaseizinger has an idea right away.

Failures are due to #4714. It touched various files across many crates adding #[allow(deprecated)]. Under the assumptions that the warnings without it don't show up on the user side, that in itself I guess is not release worthy for each of the crates.

I am adding the internal-change label here. Thus this pull request does not need to block on the above releases either.

[mxinden]

Tagged and published @b-zee.

[thomaseizinger]

@mxinden I thought we generally don't try and please CI unnecesarily in backports :)

[b-zee]

Thanks a lot, @mxinden! 🙏