fix(request-response): Report failures#4701
Merged
thomaseizinger merged 20 commits intolibp2p:refactor/req-res-on-upgradefrom Oct 26, 2023
Merged
fix(request-response): Report failures#4701thomaseizinger merged 20 commits intolibp2p:refactor/req-res-on-upgradefrom
thomaseizinger merged 20 commits intolibp2p:refactor/req-res-on-upgradefrom
Conversation
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Awesome work on discovering all these bugs. Curious what you think of making this more type-safe!
…before .await point
oblique
commented
Oct 23, 2023
mxinden
reviewed
Oct 24, 2023
Contributor
Author
|
This PR is ready. I finalized implementation and test cases |
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Great work!
I have some minor feedback for the implementation and a few ideas on how we can make the tests a bit more concise :)
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Great work! Two more minor comments :)
thomaseizinger
approved these changes
Oct 26, 2023
Contributor
|
I'll merge this directly and continue with fixing up CI in the other PR! Thanks so much of helping on this! |
mxinden
approved these changes
Oct 26, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Changes look good to me. Appreciate the additional tests and type safety!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added failure reporting. Also fixed the removal of pending jobs.
Notes & open questions
Change checklist