Skip to content

feat(swarm): deprecated keep_alive_timeout from OneShotHandlerConfig#4680

Merged
mergify[bot] merged 2 commits intolibp2p:masterfrom
leonzchang:feat/one-shot-deprecate-keep-alive-timeout
Oct 17, 2023
Merged

feat(swarm): deprecated keep_alive_timeout from OneShotHandlerConfig#4680
mergify[bot] merged 2 commits intolibp2p:masterfrom
leonzchang:feat/one-shot-deprecate-keep-alive-timeout

Conversation

@leonzchang
Copy link
Contributor

Description

Related: #3844.
Related: #4677

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • A changelog entry has been made in the appropriate crates

@leonzchang leonzchang marked this pull request as ready for review October 17, 2023 11:09
@leonzchang
Copy link
Contributor Author

Weird, multistream-select tests go well on the local.

@thomaseizinger
Copy link
Contributor

Weird, multistream-select tests go well on the local.

It is a rare flaky test unfortunately. I restarted it!

@mergify mergify bot merged commit 203e11c into libp2p:master Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants