fix(server): filter out /quic in favor of /quic-v1

[mxinden]

Description

Configuration files generated by Kubo <= v0.22 list both /quic and /quic-v1 listen addresses with the same UDP port. Given that we enable draft-29, the two addresses are treated the same by rust-libp2p's QUIC implementation. Though calling listen_on with both results in an "Address already in use" error by the OS on the second call. To prevent this from happening filter out /quic addresses in favor of /quic-v1.

Notes & open questions

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[thomaseizinger]

@mcamou This disables draft-29 support from rust-libp2p-server which means for the /quic addresses in the config, we will log a warning that we can't listen on it anymore. Is that okay? Given that we will deprecate draft-29 anyway, I figured this is a much simpler solution.

[mcamou]

@mcamou This disables draft-29 support from rust-libp2p-server which means for the /quic addresses in the config, we will log a warning that we can't listen on it anymore. Is that okay? Given that we will deprecate draft-29 anyway, I figured this is a much simpler solution.

@thomaseizinger sounds good! I think this is what we need.

[mergify]

This pull request has merge conflicts. Could you please resolve them @mxinden? 🙏

[mxinden]

Thank you. I find this an easier solution than the one I initially proposed.

[thomaseizinger]

Thank you. I find this an easier solution than the one I initially proposed.

I forgot to update the PR description though so the commit message is all wrong :/