docs: fix last OutboundQueryCompleted in kad doc#4257
Merged
mergify[bot] merged 3 commits intolibp2p:masterfrom Aug 2, 2023
thomas-senechal:master
Merged
docs: fix last OutboundQueryCompleted in kad doc#4257mergify[bot] merged 3 commits intolibp2p:masterfrom thomas-senechal:master
mergify[bot] merged 3 commits intolibp2p:masterfrom
thomas-senechal:master
Conversation
thomas-senechal
changed the title
mxinden
previously approved these changes
Jul 31, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thank you for your help @thomas-senechal!
mergify
bot
dismissed
mxinden’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
mxinden
previously approved these changes
Jul 31, 2023
mergify
bot
dismissed
mxinden’s stale review
Approvals have been dismissed because the PR was updated after the send-it label was applied.
mxinden
approved these changes
Aug 2, 2023
hanabi1224
pushed a commit
to hanabi1224/rust-libp2p
that referenced
this pull request
Aug 3, 2023
`OutboundQueryCompleted` hasn't been fully replaced by `OutboundQueryProgressed` in kad doc. Pull-Request: libp2p#4257.
thomaseizinger
pushed a commit
that referenced
this pull request
Aug 20, 2023
`OutboundQueryCompleted` hasn't been fully replaced by `OutboundQueryProgressed` in kad doc. Pull-Request: #4257.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OutboundQueryCompletedhasn't been fully replaced byOutboundQueryProgressedin kad doc.Notes & open questions
While playing with the
distributed-key-value-store, I noticed that I couldn't find theOutboundQueryCompletedanywhere except in the documentation of some functions. I checked the changelog and it looks like it has been replaced byOutboundQueryProgressed-> https://github.com/libp2p/rust-libp2p/blob/master/protocols/kad/CHANGELOG.md#0420Change checklist