Skip to content

chore(kad): extend changelog entry on client/server mode #4050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Jun 8, 2023
Merged

chore(kad): extend changelog entry on client/server mode #4050

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e850e0
chore(kad): extend changelog entry on client/server mode
mxinden Jun 8, 2023
e1e10de
Merge branch 'master' into mxinden-patch-1
mergify[bot] Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion protocols/kad/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
See [PR 3896].

- Automatically configure client/server mode based on external addresses.
If we have or learn about an external address of our node, we operate in server-mode and thus allow inbound requests.
If we have or learn about an external address of our node, e.g. through `Swarm::add_external_address` or automated through `libp2p-autonat`, we operate in server-mode and thus allow inbound requests.
By default, a node is in client-mode and only allows outbound requests.
If you want to maintain the status quo, i.e. always operate in server mode, make sure to add at least one external address through `Swarm::add_external_address`.
See also [Kademlia specification](https://github.com/libp2p/specs/tree/master/kad-dht#client-and-server-mode) for an introduction to Kademlia client/server mode.
See [PR 3877].

[PR 3715]: https://github.com/libp2p/rust-libp2p/pull/3715
Expand Down