feat(identify): push changed listen protocols to remote#3980
Merged
mergify[bot] merged 4 commits intomasterfrom May 25, 2023
Merged
feat(identify): push changed listen protocols to remote#3980mergify[bot] merged 4 commits intomasterfrom
mergify[bot] merged 4 commits intomasterfrom
Conversation
4 tasks
mxinden
approved these changes
May 25, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Very clean. Thanks. Great to see all these pieces coming together.
6 tasks
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Oct 20, 2023
Starting in #3980, we make more use of the identify push protocol by actively notifying the peer when our locally supported protocols change. We emit an event (`Pushed`) to the user in that case. This event however does not include **what** we pushed. Users might be interested in the internal changes that we push to remote peers. This patch adds the identify `Info` to the `Pushed` variant. Fixes #4332. Pull-Request: #4527.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that we have the infrastructure for notifying protocols about changes to our listen protocols, we can use this to actively push those changes to our remotes. This allows other peers to re-configure themselves with very low-latency instead of waiting for the periodic identify event.
Resolves: #3613.
Notes & open questions
Change checklist