feat(ping): don't close connections upon failures

examples/ipfs-private/src/main.rs

@@ -249,20 +249,14 @@ async fn main() -> Result<(), Box<dyn Error>> {
                         match event {
                             ping::Event {
                                 peer,
-                                result: Result::Ok(ping::Success::Ping { rtt }),
+                                result: Result::Ok(rtt),
                             } => {
                                 println!(
                                     "ping: rtt to {} is {} ms",
                                     peer.to_base58(),
                                     rtt.as_millis()
                                 );
                             }
-                            ping::Event {
-                                peer,
-                                result: Result::Ok(ping::Success::Pong),
-                            } => {
-                                println!("ping: pong from {}", peer.to_base58());
-                            }
                             ping::Event {
                                 peer,
                                 result: Result::Err(ping::Failure::Timeout),

examples/rendezvous/src/bin/rzv-discover.rs

@@ -105,7 +105,7 @@ async fn main() {
                     }
                     SwarmEvent::Behaviour(MyBehaviourEvent::Ping(ping::Event {
                         peer,
-                        result: Ok(ping::Success::Ping { rtt }),
+                        result: Ok(rtt),
                     })) if peer != rendezvous_point => {
                         log::info!("Ping to {} is {}ms", peer, rtt.as_millis())
                     }

examples/rendezvous/src/bin/rzv-identify.rs

@@ -106,7 +106,7 @@ async fn main() {
             }
             SwarmEvent::Behaviour(MyBehaviourEvent::Ping(ping::Event {
                 peer,
-                result: Ok(ping::Success::Ping { rtt }),
+                result: Ok(rtt),
             })) if peer != rendezvous_point => {
                 log::info!("Ping to {} is {}ms", peer, rtt.as_millis())
             }

examples/rendezvous/src/bin/rzv-register.rs

@@ -104,7 +104,7 @@ async fn main() {
             }
             SwarmEvent::Behaviour(MyBehaviourEvent::Ping(ping::Event {
                 peer,
-                result: Ok(ping::Success::Ping { rtt }),
+                result: Ok(rtt),
             })) if peer != rendezvous_point => {
                 log::info!("Ping to {} is {}ms", peer, rtt.as_millis())
             }

interop-tests/src/bin/ping.rs

@@ -138,7 +138,7 @@ async fn main() -> Result<()> {
         let rtt = loop {
             if let Some(SwarmEvent::Behaviour(BehaviourEvent::Ping(ping::Event {
                 peer: _,
-                result: Ok(ping::Success::Ping { rtt }),
+                result: Ok(rtt),
             }))) = swarm.next().await
             {
                 log::info!("Ping successful: {rtt:?}");

misc/metrics/CHANGELOG.md

@@ -26,9 +26,13 @@
   Note that you can use the `_count` metric of the `Histogram` as a replacement for the `Counter`.
   See [PR 3927].
 
+- Remove the `pong_received` counter because it is no longer exposed by `libp2p-ping`.
+  See [PR 3947].
+
 [PR 3715]: https://github.com/libp2p/rust-libp2p/pull/3715
 [PR 3927]: https://github.com/libp2p/rust-libp2p/pull/3927
 [PR 3325]: https://github.com/libp2p/rust-libp2p/pull/3325
+[PR 3947]: https://github.com/libp2p/rust-libp2p/pull/3947
 
 ## 0.12.0
 

misc/metrics/src/ping.rs

@@ -55,7 +55,6 @@ enum Failure {
 pub(crate) struct Metrics {
     rtt: Histogram,
     failure: Family<FailureLabels, Counter>,
-    pong_received: Counter,
 }
 
 impl Metrics {
@@ -77,28 +76,14 @@ impl Metrics {
             failure.clone(),
         );
 
-        let pong_received = Counter::default();
-        sub_registry.register(
-            "pong_received",
-            "Number of 'pong's received",
-            pong_received.clone(),
-        );
-
-        Self {
-            rtt,
-            failure,
-            pong_received,
-        }
+        Self { rtt, failure }
     }
 }
 
 impl super::Recorder<libp2p_ping::Event> for Metrics {
     fn record(&self, event: &libp2p_ping::Event) {
         match &event.result {
-            Ok(libp2p_ping::Success::Pong) => {
-                self.pong_received.inc();
-            }
-            Ok(libp2p_ping::Success::Ping { rtt }) => {
+            Ok(rtt) => {
                 self.rtt.observe(rtt.as_secs_f64());
             }
             Err(failure) => {

protocols/ping/CHANGELOG.md

@@ -2,10 +2,16 @@
 
 - Raise MSRV to 1.65.
   See [PR 3715].
+
 - Remove deprecated items. See [PR 3702].
 
+- Don't close connections on ping failures.
+  This also removes the `max_failures` config option.
+  See [PR 3947].
+
 [PR 3715]: https://github.com/libp2p/rust-libp2p/pull/3715
 [PR 3702]: https://github.com/libp2p/rust-libp2p/pull/3702
+[PR 3947]: https://github.com/libp2p/rust-libp2p/pull/3947
 
 ## 0.42.0