feat(transport): websys-webtransport#3846
Closed
mriise wants to merge 4 commits intolibp2p:masterfrom
Closed
Conversation
mriise
changed the title
mriise
commented
Apr 27, 2023
Comment on lines
+3
to
+4
| rustflags = ["--cfg=web_sys_unstable_apis"] | ||
| rustdocflags = ["--cfg=web_sys_unstable_apis"] |
Author
There was a problem hiding this comment.
Note that these only applies when running cargo build/doc at this crate level.
Contributor
There was a problem hiding this comment.
Would it make sense to add this to the docs.rs table in the Cargo.toml?
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Looking forward to this!
| use web_sys::WebTransport; | ||
| use libp2p_core::Transport; | ||
|
|
||
| pub struct WebTransportTransport; |
Contributor
There was a problem hiding this comment.
Suggested change
| pub struct WebTransportTransport; | |
| pub struct Transport; |
See #2217 for the naming convention we are trying to follow.
Comment on lines
+3
to
+4
| rustflags = ["--cfg=web_sys_unstable_apis"] | ||
| rustdocflags = ["--cfg=web_sys_unstable_apis"] |
Contributor
There was a problem hiding this comment.
Would it make sense to add this to the docs.rs table in the Cargo.toml?
This was referenced May 25, 2023
Closed
4 tasks
4 tasks
Contributor
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
This PR implements `Transport` for WebTransport for browsers by using web-sys. Related: #3846. Resolves: #3825. Pull-Request: #4015. Co-Authored-By: Yiannis Marangos <[email protected]> Co-Authored-By: Maciej Zwoliński <[email protected]> Co-Authored-By: Yiannis Marangos <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
WIP Draft
Notes & open questions
Change checklist