fix(gossipsub): always honor support_floodsub setting#3837
Merged
mergify[bot] merged 10 commits intomasterfrom Apr 27, 2023
Merged
fix(gossipsub): always honor support_floodsub setting#3837mergify[bot] merged 10 commits intomasterfrom
support_floodsub setting#3837mergify[bot] merged 10 commits intomasterfrom
Conversation
thomaseizinger
commented
Apr 26, 2023
4 tasks
AgeManning
approved these changes
Apr 26, 2023
Contributor
AgeManning
left a comment
AgeManning
left a comment
There was a problem hiding this comment.
Yeah looks like an oversight. Nice catch.
mxinden
approved these changes
Apr 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, we only honored the
support_floodsubsetting when the user did not specify a custom protocol for gossipsub. This patch fixes this and allows users to advertise floodsub even when they use a custom protocol.Notes & open questions
cc @AgeManning I believe this is an oversight. Let me know in case this was intentional. I don't see a reason why we should silently ignore this setting when using a custom protocol identifier.
Change checklist