feat(core): deprecate OptionalUpgrade#3806
Merged
mergify[bot] merged 7 commits intomasterfrom Apr 26, 2023
Merged
Conversation
thomaseizinger
commented
Apr 19, 2023
4 tasks
This comment was marked as resolved.
This comment was marked as resolved.
…ibp2p into deprecate-optional-upgrade
4 tasks
mxinden
previously approved these changes
Apr 25, 2023
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Can not find an external user of it either.
mergify bot
pushed a commit
that referenced
this pull request
Apr 25, 2023
These functions were only used for some code in the interop-tests which is easily mitigated and perhaps even easier to understand now. We can thus deprecate these functions and their related types and thereby reduce the API surface of `libp2p-core` and the maintenance burden. This change is motivated by the work around making protocols always strings which requires/required updates to all these upgrades. Related #3806. Related #3271. Related #3745. Pull-Request: #3807.
This comment was marked as resolved.
This comment was marked as resolved.
mxinden
approved these changes
Apr 26, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is dead-code, we don't use it in our codebase. I am suggesting to remove it because it creates an unnecessary API surface.
Related: #3747.
Related: #3271.
Notes & open questions
Change checklist