feat(noise): deprecate all handshake patterns apart from XX#3768
Merged
mergify[bot] merged 15 commits intomasterfrom Apr 28, 2023
Merged
feat(noise): deprecate all handshake patterns apart from XX#3768mergify[bot] merged 15 commits intomasterfrom
mergify[bot] merged 15 commits intomasterfrom
Conversation
18 tasks
This comment was marked as resolved.
This comment was marked as resolved.
`pub type` aliases don't export the enum contructors unfortunately.
This comment was marked as resolved.
This comment was marked as resolved.
4 tasks
mxinden
reviewed
Apr 25, 2023
Member
mxinden
left a comment
There was a problem hiding this comment.
Thanks for the additional simplifications via Config!
Contributor
Author
|
Thanks for catching the missing version bumps. I am looking forward to #3715 when this no longer requires a manual check. I did not bump the versions of the dependent crates. I figured, just bump dependencies is not worth it. Do you agree? |
This comment was marked as resolved.
This comment was marked as resolved.
mxinden
previously approved these changes
Apr 26, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the libp2p specs, the only handshake pattern that is specified is the XX handshake. Support for other handshake patterns can be added through external modules. While we are at it, we rename the remaining types to following the laid out naming convention.
The tests for handshakes other than XX are removed. The handshakes still work as we don't touch them in this patch.
Related #2217.
Notes & open questions
Change checklist