fix(examples): subscribe to topic in chat-tokio#3296
Merged
mergify[bot] merged 2 commits intolibp2p:masterfrom Jan 4, 2023
Merged
fix(examples): subscribe to topic in chat-tokio#3296mergify[bot] merged 2 commits intolibp2p:masterfrom
mergify[bot] merged 2 commits intolibp2p:masterfrom
Conversation
Member
|
@Mergifyio refresh |
Contributor
✅ Pull request refreshed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With #3097, subscribing to the floodsub topic in
examples/chat-tokio.rswas removed. I assume this was unintentional (cc @umgefahren), so this PR adds it back.Links to any relevant issues
Most likely the reason why the example did not work in #3217.
Change checklist
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksA changelog entry has been made in the appropriate crates