fix(swarm): Make executors pub and add convenience constructors for SwarmBuilder#3155
Merged
mergify[bot] merged 3 commits intolibp2p:masterfrom Nov 23, 2022
Merged
fix(swarm): Make executors pub and add convenience constructors for SwarmBuilder#3155mergify[bot] merged 3 commits intolibp2p:masterfrom
mergify[bot] merged 3 commits intolibp2p:masterfrom
Conversation
7 tasks
Member
|
thank you! |
thomaseizinger
approved these changes
Nov 22, 2022
Contributor
|
I'd like to merge libp2p/test-plans#77 first so we have a green CI. |
mxinden
approved these changes
Nov 23, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
As always, very much appreciate the help @umgefahren!
| @@ -1,3 +1,4 @@ | |||
| //! Provides executors for spawning background tasks. | |||
Member
There was a problem hiding this comment.
Oversight on my end on #3097: Would you mind adding a license header here? See other files in the repository.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses issues raised here: #3097 (comment)
Links to any relevant issues
Follows from #3097.
Change checklist