core/identity: Implement Hash and Ord for PublicKey#2915
Merged
mxinden merged 12 commits intolibp2p:masterfrom Sep 22, 2022
Merged
core/identity: Implement Hash and Ord for PublicKey#2915mxinden merged 12 commits intolibp2p:masterfrom
Hash and Ord for PublicKey#2915mxinden merged 12 commits intolibp2p:masterfrom
Conversation
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thank you for working on this!
I've left a few comments :)
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
futpib
force-pushed
the
public-key-hash-ord
branch
from
a1bb1e1 to
05f3000
Compare
futpib
force-pushed
the
public-key-hash-ord
branch
from
05f3000 to
8292a78
Compare
thomaseizinger
requested changes
Sep 20, 2022
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thanks for following up with this! Please see inline comment.
…s implemented manually.
thomaseizinger
approved these changes
Sep 21, 2022
Contributor
thomaseizinger
left a comment
thomaseizinger
left a comment
There was a problem hiding this comment.
Thank you! :)
I've triggered CI. One last comment, otherwise this should be good to go in!
Co-authored-by: Thomas Eizinger <thomas@eizinger.io>
mxinden
approved these changes
Sep 21, 2022
Member
mxinden
left a comment
mxinden
left a comment
There was a problem hiding this comment.
Thanks @futpib for the patch and @thomaseizinger for the guidance.
Member
|
Interoperability test failures due to libp2p/test-plans#41. Merging here. |
thomaseizinger
changed the title
Hash and Ord for PublicKey
Contributor
|
Fixed the merge conflicts :) |
…ublic-key-hash-ord
Member
|
Interoperability tests failing due to libp2p/test-plans#41. Merging here. Thanks @futpib! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented
OrdandHashinstances forPublicKeyto enable putting them in aHashSet/BTreeSet.Links to any relevant issues
Fixes #2910
Open Questions
Change checklist