Closed
Conversation
nazar-pc
reviewed
May 23, 2022
Contributor
nazar-pc
left a comment
nazar-pc
left a comment
There was a problem hiding this comment.
Makes sense to me, though consensus needs to be reached on whether to include this in the first place.
Contributor
|
I am converting this to a draft until this lands in the specs repo. |
Contributor
|
This pull request has merge conflicts. Could you please resolve them @i1i1? 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pr is followup of spec issue. It adds support for sr25519 keys for libp2p.
Links to any relevant issues
Open Questions
Change checklist